Re: 'converts internal representation to "..."' comment is confusing

Поиск
Список
Период
Сортировка
От Steve Chavez
Тема Re: 'converts internal representation to "..."' comment is confusing
Дата
Msg-id CAGRrpzbMkhoKJ_4ZWhAL99grMn_WmQKw1qXU9mvUJO6ifveisA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: 'converts internal representation to "..."' comment is confusing  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения
Thanks a lot for the clarification!

The "..." looks enigmatic right now. I think cstring would save newcomers some head-scratching.

Open to suggestions though.

Best regards,
Steve 

On Sun, 14 May 2023 at 22:36, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Steve Chavez <steve@supabase.io> writes:
> I found "..." confusing in some comments, so this patch changes it to
> "cstring". Which seems to be the intention after all.

Those comments are Berkeley-era, making them probably a decade older
than the "cstring" pseudotype (invented in b663f3443).  Perhaps what
you suggest is an improvement, but I'm not sure that appealing to
original intent can make the case.

                        regards, tom lane

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Zhijie Hou (Fujitsu)"
Дата:
Сообщение: RE: walsender performance regression due to logical decoding on standby changes
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~