[pgAdmin4][PATCH] Refactor and change of implementation ofkeyboard_shortcuts function dependencies

Поиск
Список
Период
Сортировка
От Sarah McAlear
Тема [pgAdmin4][PATCH] Refactor and change of implementation ofkeyboard_shortcuts function dependencies
Дата
Msg-id CAGRPzo9G70LPFmRkNC5awGAojA-c2_Ek0Bxui=wtkD_1pEg+aA@mail.gmail.com
обсуждение исходный текст
Ответы Re: [pgAdmin4][PATCH] Refactor and change of implementation ofkeyboard_shortcuts function dependencies  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Список pgadmin-hackers
Hi Hackers!

Attached is a patch that extracts the functions called by the keyboard_shortcuts function extracted earlier from sqlEditor. This includes 
  • executeQuery
  • explainAnalyze
  • explain
  • download
  • commentBlockCode
  • commentLineCode
  • uncommentLineCode

There is still more work to be done, but this is it for now. 

There is also an additional patch that changes the implementation of the commentLineCode, uncommentLineCode, and commentBlockCode functions. The shortcut 
  • for commentLineCode is now  cmd + / (ctrl + / for Windows)
  • for uncommentLineCode cmd + . (ctrl + . for Windows)
  • for comment and uncomment blockCode shift + cmd + / (shift + ctrl + / for Windows)
This is consistent with other IDEs and the way commenting is implemented. 

Thanks!
Hao & Sarah
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Murtuza Zabuawala
Дата:
Сообщение: [pgAdmin4][Patch]: Use the correct resultset type for Type module
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin4][Patch]: To fix Collation tests