Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements indata-grid/query tool

Поиск
Список
Период
Сортировка
От Sarah McAlear
Тема Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements indata-grid/query tool
Дата
Msg-id CAGRPzo9EJkPQR7NnmrrNoi3Pmve5Se=TWyOy1qm0MRkpaceQcg@mail.gmail.com
обсуждение исходный текст
Ответ на [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Ответы Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements indata-grid/query tool  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
Hi Surinder!

We reviewed the patch and the changes look great. Could you change the grays to match the style guide? 

Silver, #222, and #aaa aren't listed in pgadmin.style.css. 

Thanks so much!
Shirley & Sarah

On Thu, Jun 8, 2017 at 9:34 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

Changes:

1) Display only border-top for data-grid header instead of border on whole data-grid.

2) Remove dotted border from cell right for consistency.

3) Add border-bottom for header-row so that on scroll to bottom header rows are differentiated from cells.

Also, due to these changes, the vertical scrollbar which appears at data-grid right side seems to fixed.

PFA patch and review.


Thanks,
Surinder


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Atul Sharma
Дата:
Сообщение: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if clickon statistic tab for PG 10 server
Следующее
От: Dave Page
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query ResultsGrid User Experience