Re: Per-table storage parameters for TableAM/IndexAM extensions

Hi,

Currently all the storage options for a table are very much specific
to the heap but a different AM might need some user defined AM
specific parameters to help tune the AM. So here is a patch which
provides an AM level routine so that instead of getting parameters
validated using “heap_reloptions” it will call the registered AM
routine.

e.g:
-- create a new access method and table using this access method
CREATE ACCESS METHOD myam TYPE TABLE HANDLER <new_tableam_handler>;

CREATE TABLE mytest (a int) USING myam ;

--a new parameter is to set storage parameter for only myam as below
ALTER TABLE mytest(squargle_size = '100MB');

The user-defined parameters will have meaning only for the "myam",
otherwise error will be thrown. Our relcache already allows the
AM-specific cache to be stored for each relation.

Open Question: When a user changes AM, then what should be the
behavior for not supported storage options? Should we drop the options
and go with only system storage options?
Or throw an error, in which case the user has to clean the added parameters.

@@ -1372,7 +1373,8 @@ untransformRelOptions(Datum options)
  */
 bytea *
 extractRelOptions(HeapTuple tuple, TupleDesc tupdesc,
-  amoptions_function amoptions)
+ amoptions_function amoptions,
+ reloptions_function taboptions)

  case RELKIND_MATVIEW:
            options = table_reloptions(taboptions, classForm->relkind, datum, false);
break;

diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c
index 9befe01..6324d7e 100644
--- a/src/backend/access/heap/heapam_handler.c
+++ b/src/backend/access/heap/heapam_handler.c
@@ -2581,6 +2581,7 @@ static const TableAmRoutine heapam_methods = {
  .index_build_range_scan = heapam_index_build_range_scan,
  .index_validate_scan = heapam_index_validate_scan,
 
+ .taboptions = heap_reloptions,

@@ -2427,7 +2428,7 @@ do_autovacuum(void)
  */
  MemoryContextSwitchTo(AutovacMemCxt);
  tab = table_recheck_autovac(relid, table_toast_map, pg_class_desc,
- effective_multixact_freeze_max_age);
+ classRel->rd_tableam->taboptions, effective_multixact_freeze_max_age);
  if (tab == NULL)