Re: alter user/role CURRENT_USER

<div dir="ltr">I gone through patch and here is the review for this patch:<br /><br /><br />.) patch go applied on
masterbranch with patch -p1 command<br />   (git apply failed)<br />.) regression make check run fine<br />.) testcase
coverageis missing in the patch<br />.) Over all coding/patch looks good.<br /><br />Few comments:<br /><br />1) Any
particularreason for not adding SESSION_USER/USER also made usable<br />for this command ?<br /><br />2) I think
RoleId_or_currusercan be used for following role:<br /><br />    /* ALTER TABLE <name> OWNER TO RoleId */<br />  
        | OWNER TO RoleId<br /><br />3) In the documentation patch, added for CURRENT_USER but CURRENT_ROLE is<br
/>missing.<br/><br /></div><div class="gmail_extra"><br /><div class="gmail_quote">On Fri, Oct 10, 2014 at 1:57 PM,
KyotaroHORIGUCHI <span dir="ltr"><<a href="mailto:horiguchi.kyotaro@lab.ntt.co.jp"
target="_blank">horiguchi.kyotaro@lab.ntt.co.jp</a>></span>wrote:<br /><blockquote class="gmail_quote"
style="margin:00 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello, on the way considering alter role set .., I
foundthat<br /> ALTER ROLE/USER cannot take CURRENT_USER as the role name.<br /><br /> In addition to that, documents
ofALTER ROLE / USER are<br /> inconsistent with each other in spite of ALTER USER is said to be<br /> an alias for
ALTERROLE. Plus, ALTER USER cannot take ALL as user<br /> name although ALTER ROLE can.<br /><br /> This patch does
followingthings,<br /><br />  - ALTER USER/ROLE now takes CURRENT_USER as user name.<br /><br />  - Rewrite sysnopsis
ofthe documents for ALTER USER and ALTER<br />    ROLE so as to they have exactly same syntax.<br /><br />  - Modify
syntaxof ALTER USER so as to be an alias of ALTER ROLE.<br /><br />    - Added CURRENT_USER/CURRENT_ROLE syntax to
both.<br/>    - Added ALL syntax as user name to ALTER USER.<br />    - Added IN DATABASE syntax to ALTER USER.<br
/><br/>    x Integrating ALTER ROLE/USER syntax could not be done because of<br />      shift/reduce error of bison.<br
/><br/>  x This patch contains no additional regressions. Is it needed?<br /><br /> SESSION_USER/USER also can be made
usablefor this command, but<br /> this patch doesn't so (yet).<br /><br /> regards,<br /><span class="HOEnZb"><font
color="#888888"><br/> --<br /> Kyotaro Horiguchi<br /> NTT Open Source Software Center<br /></font></span><br /><br />
--<br/> Sent via pgsql-hackers mailing list (<a
href="mailto:pgsql-hackers@postgresql.org">pgsql-hackers@postgresql.org</a>)<br/> To make changes to your
subscription:<br/><a href="http://www.postgresql.org/mailpref/pgsql-hackers"
target="_blank">http://www.postgresql.org/mailpref/pgsql-hackers</a><br/><br /></blockquote></div><br /><br clear="all"
/><br/>-- <br />Rushabh Lathia </div>