On Fri, Dec 15, 2017 at 12:18 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > On 12/13/17 23:31, Rushabh Lathia wrote: >> PFA patch, where introduced new AclObjectKind (ACL_KIND_PROCEDURE), >> msg for the new AclObjectKind, and passed it through at >> appropriate places. > > Yeah, that's a way to do it, but having both ACL_KIND_PROC and > ACL_KIND_PROCEDURE is clearly confusing. The above-mentioned patch > cleans that up more thoroughly, I think.
+1. I looked at the patch of Peter, as well as this one, and I prefer Peter's approach of reducing duplications in concepts.