Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM

Поиск
Список
Период
Сортировка
От Rushabh Lathia
Тема Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM
Дата
Msg-id CAGPqQf0G7Q=ceN3Mq1na76nMmH65a253F6FX74t7N2MfZG+euQ@mail.gmail.com
обсуждение исходный текст
Ответ на [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Ответы Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM  (vignesh C <vignesh21@gmail.com>)
Список pgsql-hackers


On Fri, Jun 26, 2020 at 3:16 PM Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
Hi Hackers,

There seems to be an extra palloc of 64KB of raw_buf for binary format
files which is not required
as copy logic for binary files don't use raw_buf, instead, attribute_buf
is used in CopyReadBinaryAttribute.

+1

I looked at the patch and the changes looked good. Couple of comments;

1)

+
+ /* For binary files raw_buf is not used,
+ * instead, attribute_buf is used in
+ * CopyReadBinaryAttribute. Hence, don't palloc
+ * raw_buf.
+ */

Not a PG style of commenting.

2)  In non-binary mode, should assign NULL the raw_buf.

Attaching patch with those changes.



Attached is a patch, which places a check to avoid this unnecessary 64KB palloc.

Request the community to take this patch, if it is useful.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com


Thanks,
Rushabh Lathia
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: xid wraparound danger due to INDEX_CLEANUP false
Следующее
От: Robert Haas
Дата:
Сообщение: Re: [Patch] ALTER SYSTEM READ ONLY