Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE

Поиск
Список
Период
Сортировка
От Melih Mutlu
Тема Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE
Дата
Msg-id CAGPVpCTrRDho5xguMbsro-BhHoz94BLC52JXgzGWGPKFnTVcQg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE  (vignesh C <vignesh21@gmail.com>)
Ответы Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE
Список pgsql-hackers
Дерево обсуждения
Hi Vignesh,

Looks like the patch needs a rebase.

Also one little suggestion:

+ if (ends_with(prev_wd, ')'))
+ COMPLETE_WITH(Alter_routine_options, "CALLED ON NULL INPUT",
+  "RETURNS NULL ON NULL INPUT", "STRICT", "SUPPORT");

What do you think about gathering FUNCTION options as you did with ROUTINE options. 
Something like the following would seem nicer, I think.

#define Alter_function_options \
Alter_routine_options, "CALLED ON NULL INPUT", \
"RETURNS NULL ON NULL INPUT", "STRICT", "SUPPORT"

Best,
--
Melih Mutlu
Microsoft

В списке pgsql-hackers по дате отправления: