Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()

Поиск
Список
Период
Сортировка
От Jelte Fennema
Тема Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()
Дата
Msg-id CAGECzQR6p6HuMxPVNmovW0n5pAyBjDDz661hR1D9FwsKRuMH=A@mail.gmail.com
обсуждение исходный текст
Ответ на [PATCH] Align GSS and TLS error handling in PQconnectPoll()  (Jacob Champion <jchampion@timescale.com>)
Ответы Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll()  (Jacob Champion <jchampion@timescale.com>)
Список pgsql-hackers
Дерево обсуждения 
Patch looks good to me. Definitely an improvement over the status quo.

Looking at the TLS error handling though I see these two lines:

&& conn->allow_ssl_try    /* redundant? */
&& !conn->wait_ssl_try) /* redundant? */

Are they actually redundant like the comment suggests? If so, we
should probably remove them (in another patch). If not (or if we don't
know), should we have these same checks for GSS?

В списке pgsql-hackers по дате отправления:

Предыдущее
От: John Naylor
Дата:
Сообщение: Re: Todo: Teach planner to evaluate multiple windows in the optimal order
Следующее
От: Daniel Gustafsson
Дата:
Сообщение: Re: Missing default value of createrole_self_grant in document