Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
Дата
Msg-id CAG7mmozwV51hVVPpNx5A6Q184bMvvdbE-iC6FSO-A1oL2J6iEw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Список pgadmin-hackers
Thanks - committed!

Thanks Arun for the quick review!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Fri, Apr 29, 2016 at 11:34 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

More specifically to the issue.
I am using SqlFieldControl in View for Definition Field which takes default height of 300px which is set by Control as default height. but as per dave's suggestion on thread


"The Definition box on the View dialogue should start at a single
line and expand as needed - see the Function dialogue".

If user still need some height for control, It can be specified in extraclasses[] parameter which will apply to the specific field.



On Thu, Apr 28, 2016 at 7:02 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

The SqlFieldControl is setting default height for textarea, which is not needed.
It should expand as needed as similar in SqlTabControl.

Please find the attached patch, review it.

Thanks
Surinder Kumar


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Ashesh Vashi
Дата:
Сообщение: pgAdmin 4 commit: Remove unnecessary extra classes set in the SqlFieldC
Следующее
От: Ashesh Vashi
Дата:
Сообщение: pgAdmin 4 commit: Show the resize handle on the alertify dialog.