> Hmm, that's definitely wrong - any parts of the pgadmin3 build target > should be in $SRC/pgadmin. Having it in xtra/ is acceptable if it's > being built as a library that then gets linked into other projects, > but if we're adding to pgadmin3_LDADD, then the code should definitely > not be in xtra/ but in pgadmin/. I'd prefer it not be a library > personally, so can you move it please? >
Moved from xtra/pg_scanners to pgadmin/pg_scanners.
> > 92 is fine - my point is that we support 3 different types of > PostgreSQL server, that each may have a 9.2 version with different > syntax, so if we're including the version number to allow multiple > scanners in the future, then we should also include something to > differentiate the forks - eg. pg92 for PostgreSQL, as92 for Postgres > Plus Advanced Server and gp92 for Greenplum Database. >
For now, pgadmin/pg_scanners contains only pg92 scanner !