Re: PGAdmin 4 architecture (Was: [Patch] PGAdmin 4 JSON Handling)

Поиск

Список

Период

Сортировка

От	Ashesh Vashi
Тема	Re: PGAdmin 4 architecture (Was: [Patch] PGAdmin 4 JSON Handling)
Дата	23 апреля 2015 г. 11:19:16
Msg-id	CAG7mmozT8wSfqCY_B4pFCBOfAL4UJ9Vueb_VTLPAP8fTCPqH9g@mail.gmail.com обсуждение исходный текст
Ответ на	Re: PGAdmin 4 architecture (Was: [Patch] PGAdmin 4 JSON Handling) (Ronan Dunklau <ronan.dunklau@dalibo.com>)
Ответы	Re: PGAdmin 4 architecture (Was: [Patch] PGAdmin 4 JSON Handling)
Список	pgadmin-hackers

Дерево обсуждения

On Thu, Apr 23, 2015 at 12:52 PM, Ronan Dunklau <ronan.dunklau@dalibo.com> wrote:

Le jeudi 23 avril 2015 10:53:48 Ashesh Vashi a écrit :
> Hi Dave/Ronan,
>
> On Mon, Apr 20, 2015 at 4:10 PM, Dave Page <dpage@pgadmin.org> wrote:
> > On Mon, Apr 20, 2015 at 10:52 AM, Ronan Dunklau
> >
> > <ronan.dunklau@dalibo.com> wrote:
> > >> Ronan; can you update the test, help and about modules as well please?
> > >
> > > Done, please find attached a new patch for that. Ashesh, once you're
> >
> > done with
> >
> > > what you are doing now, feel free to ask me for any help needed to
> >
> > integrate
> >
> > > this after the fact.
> >
> > Thanks.
>
> Thanks - It looks good to me.
> (And, attached patch is based on that.)

Maybe I'm missing something, but it seems like a "generate_browser_node" function is missing:

File "/home/ro/projets/pgadmin4/web/pgadmin/browser/server_groups/__init__.py", line 21, in <module>
from pgadmin.browser.utils import generate_browser_node
ImportError: cannot import name generate_browser_node

It also brought to my attention that I should have removed the only function (register_modules) from pgadmin.browser.utils.

Yeah - it is missing.

Please find a separate patch for the utils.

Actually - you removed the web/pgadmin/browser/utils.py, hence - when I made the patch on top of yours, git detected the file as new file, and did not include the diff for it.

The attached patch is only for utils file.

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi