Re: Code Folding in Code Mirror

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема Re: Code Folding in Code Mirror
Дата
Msg-id CAG7mmoyGfaMzFx0UOxdkpvqLpM1v1D7wVS52E=90TVerYPJ+7A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Code Folding in Code Mirror  (Sarah McAlear <smcalear@pivotal.io>)
Список pgadmin-hackers
On Tue, Aug 15, 2017 at 2:33 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Ok, it does work for the cases defined. We misunderstood how it works. 
Still, could we enable this everywhere?
Yes.
What is the reason not to?
I don't see any reason not to do it.

-- Thanks, Ashesh 

Thanks,
Bing & Sarah

On Tue, Aug 15, 2017 at 5:00 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi Hackers!

We are working on unifying the CodeMirror stuff into one location. While looking at this we noticed that while there is logic for code folding, it doesn't seem to be working. Does it work for everyone else? We also started to wonder if there is a specific reason that code folding should be disabled anywhere? Would it not make more sense to have it look the same throughout pgAdmin? We understand that there are a few things that should be depending on the place in the app where it is used, such as 'editable'. Other than that, would it be acceptable to have the same configuration throughout?

Thanks,
Bing & Sarah


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Violet Cheng
Дата:
Сообщение: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display
Следующее
От: Surinder Kumar
Дата:
Сообщение: Re: [pgAdmin4][patch] update the alert style in the sub-navigation