[PATCH] pgAgent segfault

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема [PATCH] pgAgent segfault
Дата
Msg-id CAG7mmoy7ruK=HZGOt5GTFsuSF5e4+zHnagU0hJfuMUhqjZs=mw@mail.gmail.com
обсуждение исходный текст
Ответы Re: [PATCH] pgAgent segfault  (Dave Page <dave.page@enterprisedb.com>)
Список pgadmin-hackers
Hi Dave,

While debugging the issue reported by Rob, I found one segfault.
Please find the attached patch to find that fix along with another one.

1. Connection object was being accessed, which was already released.

2. Changed the logic for checking the connection object existence.

We're using "if (!ms_primaryCon)", which should convert the logic as boolean operator explicitly, which we defined for the 'DBconn' class.

I suspect some compilers (specifically windows one) may not behave that way, and instead of using the boolean operator, it checks for the pointer is NULL or not.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Ashesh Vashi
Дата:
Сообщение: Re: PGAgent 4.0 error feedback
Следующее
От: Ashesh Vashi
Дата:
Сообщение: Re: PGAgent 4.0 error feedback