Re: PATCH: Fix the issue in JSON decoding (pgAdmin4)

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема Re: PATCH: Fix the issue in JSON decoding (pgAdmin4)
Дата
Msg-id CAG7mmoxdY_KzbnOm_nKK+=KpBuHsQCMrQ9h_NKrwVwxyb=zkDw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: PATCH: Fix the issue in JSON decoding (pgAdmin4)  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Список pgadmin-hackers
At the moment - I have committed the code, but - I think, we should rely on some external utility to make it work better with date, timestamp, etc.

Please take a look at this mail-chain.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Thu, Jun 2, 2016 at 4:13 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

I was not sure about all the internal representation of psycopg date/time format against python’s datetime for JSON decoding format, so I used logical OR.

Thanks,
Murtuza

On 02-Jun-2016, at 3:10 pm, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Thu, Jun 2, 2016 at 12:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue in json decoding while dealing with date format, causing QueryTool to fail to render data.
RM#1280
Shouldn't the check have 'and' instead of 'or' bitwise operator here?
--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Ashesh Vashi
Дата:
Сообщение: pgAdmin 4 commit: Fixes #1280 - Resolved issue in json encoding while d
Следующее
От: Ashesh Vashi
Дата:
Сообщение: pgAdmin 4 commit: Fixes #1273 - Resolved an issue setting privileges on