Re: Patch : PGPASSFILE fix

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема Re: Patch : PGPASSFILE fix
Дата
Msg-id CAG7mmoxSmc4OpHQ4dSC_N_g8oD0_oTLXUkGHxrUOpCKe0kkHFw@mail.gmail.com
обсуждение исходный текст
Ответ на Patch : PGPASSFILE fix  (Prasad <prasad.s@mail.com>)
Ответы Re: Patch : PGPASSFILE fix
Список pgadmin-hackers
Дерево обсуждения
Hi Prasad,

I see couple of issues with your patch.
* Please generate the patch using 'git diff'.
  I could not apply your patch straight forwardly.
  I had to use the patch utility.

* Please follow the coding style of pgAdmin.
  You can find it at https://wiki.postgresql.org/wiki/PgAdmin_Internals#Coding_Style.
* Do not remove any of the existing code.
  It has been kept there keeping in mind about future development extending support of the existing functionality.
  You've removed couple of lines in the sysSettings::GetConfigFile(...) function, which is not good.

In your code:
* Checked only for PGPASSFILE environment variable.
* Need to check the existence of the file.
* Take required actions (if that file/parent directory does not exists).
    i.e. Create parent directory


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Sun, Mar 1, 2015 at 11:08 PM, Prasad <prasad.s@mail.com> wrote:

Hi,
 
Find attached fix for reading PGPASSFILE environment variable for pg password file.
 
regards,
Prasad

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Ashesh Vashi
Дата:
Сообщение: Re: assert "!IsAttached()" failed in SetInvokingWindow()
Следующее
От: Prasad
Дата:
Сообщение: Re: Patch : PGPASSFILE fix