Re: Build failed in Jenkins: pgadmin4-master-python34 #440

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема Re: Build failed in Jenkins: pgadmin4-master-python34 #440
Дата
Msg-id CAG7mmow7-pxmwZ665dVGvqG-NCG3F8Ux62VoKLLVanK1qR_tXA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Build failed in Jenkins: pgadmin4-master-python34 #440  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
On Mon, Jan 22, 2018 at 4:32 PM, Dave Page <dpage@pgadmin.org> wrote:
On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Dave,
>
> We need to make habit of running the following command before committing any
> javascript files.
>>
>> yarn run linter

We do - it's called when creating the bundle, which I always do when testing.

This newer version of ESLint seems to be picking up more than the
older one though.
Yeah - looks like that's the case.

I fixed all linter issues with older version of ESlint last week.

--
Thanks & Regards,

Ashesh Vashi

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Correctly display SQL of multiple objects on theSQL
Следующее
От: pgAdmin 4 Jenkins
Дата:
Сообщение: Build failed in Jenkins: pgadmin4-master-python27 #452