Re: ESLINT: On pgAdmin static javascripts

Hi

On Mon, Jan 8, 2018 at 3:18 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Mon, Jan 8, 2018 at 8:31 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

I think these are impossibly big to properly review by hand, especially where much of them are whitespace changes.

I ran both jasmine test framework, and feature tests.

Both are running fine. 

I think the best option is to check the regression tests all pass, do some manual testing yourself, and then commit. 

Done some manual testing.

It would be helpful, If somebody can help with some more testing, which I may have missed.

Please ask one of the team (other than me) :-)

 

-- Thanks, Ashesh

 

On Mon, Jan 8, 2018 at 1:55 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Dave/Team,

I found many problems while 'eslint' utility on all the static javascript files of pgAdmin 4.

i.e. <pgAdmin4_path>/web/node_module/.bin/eslint <file_name>

I had fixed all errors reported by eslint for those files.

I have created six patches for ease of maintenance, as possibilities of conflicting with other patches.

* Browser nodes javascript files

* Browser specific javascript files

* pgAdmin common javascript files

* SQLEditor/DataGrid javascript files

* Tools javascript files

* Miscellaneous modules javascript files

All patches are independent of each other.

Please review it, and share your opinion.

  

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company