Re: [PATCH] Improve autocompletion for SELECT statements

Поиск
Список
Период
Сортировка
От Wander Winkelhorst
Тема Re: [PATCH] Improve autocompletion for SELECT statements
Дата
Msg-id CAFv2D8tB1kD7J8JPFbLSA21Fs-nVG3MaKTTTYh4Ht1bjsDSYEQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Improve autocompletion for SELECT statements  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [PATCH] Improve autocompletion for SELECT statements  (Dave Page <dpage@pgadmin.org>)
Re: [PATCH] Improve autocompletion for SELECT statements  (Kris Shannon <kris@shannon.id.au>)
Список pgadmin-hackers


On Tue, Nov 15, 2011 at 10:03 AM, Dave Page <dpage@pgadmin.org> wrote:
On Mon, Nov 14, 2011 at 8:15 PM, Wander Winkelhorst
<w.winkelhorst@gmail.com> wrote:
>
>
> On Mon, Nov 14, 2011 at 10:16 AM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> FYI, I just took a look at the patch and it does touch
>> tab-complete.inc - it certainly should *not* do that, as
>> tab-complete.inc is generated with tabcomplete.pl from the upstream
>> tab-complete.c. Any changes made to it are likely to be lost the next
>> time it's updated. If that file must be changed, then it should be
>> done by tab-complete.pl, though frankly it would be better to push the
>> changes into psql first.
>
> Could you please tell me how I'm supposed to use tabcomplete.pl, and where I
> can get the correct version of  tab-complete.c?

I'm not sure I've ever used it - that was originally written by Magnus
so I think he handled it originally.

The top of the script has this:

# This script builds tab-complete.inc from tab-complete.c. The
# source file (tab-complete.c) should be copied from the latest
# PostgreSQL sources (src/bin/psql/tab-complete.c), so we don't
# have to do all the work ourselves...

By the looks of it you copy tab-complete.c to pgadmin/utils, and then
run the script in that directory.
 
Yeah, I've tried that, didn't work. tabcomplete.pl says "Failed match 1 at tabcomplete.pl line 28."

I wouldn't be surprised if it needs
updating though; the tab completion code does get hacked on quite
regularly in PostgreSQL.

So, should I just get the latest version of tab-complete.c, and base my work on that? I'd be doing to separate things in one patch, which I don't like, but if this is what gets my changes in pgadmin, I'd do it.

Regards,
Wander Winkelhorst.

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [PATCH] Improve autocompletion for SELECT statements
Следующее
От: Dave Page
Дата:
Сообщение: Re: [PATCH] Improve autocompletion for SELECT statements