Re: [pgAdmin][RM4681] Increase cache control max age for static files
| От | Avin Kavish |
|---|---|
| Тема | Re: [pgAdmin][RM4681] Increase cache control max age for static files |
| Дата | |
| Msg-id | CAFpscOSAwitz-5uhAuQ_jqT1ymOU1J3x+F-OvtEho3xtUM1iyw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [pgAdmin][RM4681] Increase cache control max age for static files (Ashesh Vashi <ashesh.vashi@enterprisedb.com>) |
| Список | pgadmin-hackers |
If content hashing is enabled on webpack, cache time can even be 10 years as the file names will update and effectively invalidate the old caches. If content hashing or some other cache busting mechanism is not enabled, it might be a problem.
In my experience, it is good to have one year, browsers usually re-download resources marked for 30 days quite often
On Thu., 29 Aug. 2019, 10:59 am Ashesh Vashi, <ashesh.vashi@enterprisedb.com> wrote:
On Wed, Aug 28, 2019 at 1:32 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:I have done the review, it looks good to me.Hi Hackers,Attached is the patch to increase cache control max age (in http header) for static files to improve performance over longer run.By default it is 43200 seconds (12 hrs), which means that the static files like vendor.js, etc. will be fetched again from server after 12hrs. This is not required as these files won't change.Kindly review.I have only concern about - with this change the caching will be done for at least 1 year. I am still kind of confused, what should be the caching time?But - we can go ahead with this change.--Thanks and Regards,Aditya ToshniwalSoftware Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
В списке pgadmin-hackers по дате отправления: