Re: GetExistingLocalJoinPath() vs. the docs

Поиск
Список
Период
Сортировка
От Ashutosh Bapat
Тема Re: GetExistingLocalJoinPath() vs. the docs
Дата
Msg-id CAFjFpRfZnunua5RnAieop5DYXQy+cWJKhFVwWYo2dcaKocwJTg@mail.gmail.com
обсуждение исходный текст
Ответ на GetExistingLocalJoinPath() vs. the docs  (Stephen Frost <sfrost@snowman.net>)
Ответы Re: GetExistingLocalJoinPath() vs. the docs  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers


On Mon, Feb 15, 2016 at 9:11 PM, Stephen Frost <sfrost@snowman.net> wrote:
Greetings,

While getting back into the thread Re: Optimization for updating foreign
tables in Postgres FDW, I noticed some issues with the docs and
GetExistingLocalJoinPath():

GetExistingLocalJoinPath() exists in src/backend/foreign/foreign.c, but
the docs include discussion of it under 54.2 - Foreign Data Wrapper
Callback Routines.  Shouldn't this be under 54.3. Foreign Data Wrapper
Helper Functions? 

Yes
 
Also, the prototype is incorrect in the docs (it
doesn't return a void)

Thanks for pointing that out.
 
and the paragraph about what it's for could do
with some wordsmithing.

Any specific suggestions?
 

A link from 54.2 to 54.3 which mentions it would be fine, of course.

Ok
 
PFA patch fixing those things.


--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Craig Ringer
Дата:
Сообщение: Re: Packaging of postgresql-jdbc
Следующее
От: Robert Haas
Дата:
Сообщение: Re: Declarative partitioning