[HACKERS] Re: [COMMITTERS] pgsql: Expand partitioned table RTEs level by level,without flattening

Поиск
Список
Период
Сортировка
От Ashutosh Bapat
Тема [HACKERS] Re: [COMMITTERS] pgsql: Expand partitioned table RTEs level by level,without flattening
Дата
Msg-id CAFjFpReT9=gazzvYG_qb6fXC-ZxtvTy8faULQKXqh_ogHShK_w@mail.gmail.com
обсуждение исходный текст
Ответы Re: [HACKERS] Re: [COMMITTERS] pgsql: Expand partitioned table RTEslevel by level, without flattening  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
On Sun, Sep 17, 2017 at 7:24 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> Can you debug this on Monday?
>
> ...Robert
>
> Begin forwarded message:
>
> From: Andreas Seltenreich <seltenreich@gmx.de>
> Date: September 16, 2017 at 6:55:46 AM EDT
> To: Robert Haas <rhaas@postgresql.org>
> Cc: pgsql-committers@postgresql.org
> Subject: Re: [COMMITTERS] pgsql: Expand partitioned table RTEs level by
> level, without flattening
>
> Robert Haas writes:
>
> Expand partitioned table RTEs level by level, without flattening.
>
>
> testing with sqlsmith shows that the following assertion in this commit
> doesn't hold:
>
> TRAP: FailedAssertion("!(((brel)->reloptkind == RELOPT_BASEREL ||
> (brel)->reloptkind == RELOPT_OTHER_MEMBER_REL))", File: "initsplan.c", Line:
> 647)
>
> One of the simpler queries that triggers it for me:
>
>    select from information_schema.user_mapping_options;

Thanks Andreas for the report. Sorry for the assertion failure.

PFA patch to fix the assertion failure.

The assertion assumed that all relations in simple_rel_array[] were
either "base" relations or "other" relations. This isn't true. The
array can contain "dead" relations as well. I have removed the
assertion and instead fixed the code to skip anything which is not
"base" or "other member rel".

I have also added a test to cover dead relations and lateral
references in join.sql.

-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Rushabh Lathia
Дата:
Сообщение: Re: [HACKERS] GatherMerge misses to push target list
Следующее
От: Mithun Cy
Дата:
Сообщение: Re: [HACKERS] SendRowDescriptionMessage() is slow for queries with alot of columns