Pointer to structure in ECPG

This happens because of two problems

1. When dumping individual members of structure emp in test_select.pgc, when a pointer to that structure is dumped, its array size is dumped as "1" instead of "0" or a negative number like scalar variable pointers.

2. As discussed in other thread "using arrays within structure in ECPG", the offsets of members of structures are not dumped correctly for an unbounded array.

Problem 1 reason:
-------------------------
When dumping individual members of structure emp in test_select.pgc, when a pointer to that structure is dumped, the call is routed through code path as shown below

#0  ECPGdump_a_type (o=0x6cc4f0, name=0x6d2190 "empno", type=0x6d2130, brace_level=-1, ind_name=0x4c0ae8 "no_indicator", ind_type=0x6c8260, ind_brace_l
evel=-1, prefix=0x6d1a20 "emp2->", ind_prefix=0x0, arr_str_siz=0x6d2070 "0", struct_sizeof=0x6d0c60 "sizeof( struct employee )", ind_struct_sizeof=0x0)
 at type.c:247
#1  0x000000000042f21d in ECPGdump_a_struct (o=0x6cc4f0, name=0x6d20b0 "emp2", ind_name=0x435c20 "no_indicator", arrsiz=0x6d2070 "0", type=0x6d20d0, in
d_type=0x6c8260, prefix=0x6d1a20 "emp2->", ind_prefix=0x0) at type.c:572
#2  0x000000000042e2cc in ECPGdump_a_type (o=0x6cc4f0, name=0x6d20b0 "emp2", type=0x6d22b0, brace_level=1, ind_name=0x435c20 "no_indicator", ind_type=0
x6c8260, ind_brace_level=0, prefix=0x0, ind_prefix=0x0, arr_str_siz=0x6d1e60 "0", struct_sizeof=0x0, ind_struct_sizeof=0x0) at type.c:293
#3  0x000000000043335d in dump_variables (list=0x6d2310, mode=1) at variable.c:452

ECPGdump_a_type() at frame #3, then calls ECPGdump_a_simple() as follows
#0  ECPGdump_a_simple (o=0x6cc4f0, name=0x6d2190 "empno", type=ECPGt_int, varcharsize=0x6d0f70 "1", arrsize=0x6d2360 "-1", siz=0x6d0c60 "sizeof( struct
 employee )", prefix=0x6d1a20 "emp2->", counter=0) at type.c:405

ECPGdump_a_simple() while dumping the member (here empno) dumps with arrsize = "1" instead of "-1" because of code at line
523│                 if (atoi(arrsize) < 0)
524│                         strcpy(arrsize, "1");

In ECPG run time library when reading this variable, it is read with array size 1 and is falsely interpreted as an array with size 1 instead of an unbounded array (which are read with arrsize < 0). Hence giving error -203.

ECPGdump_a_struct has correctly called ECPGdump_a_type with arrsize "0" to mean an unbounded array, and ECPGdump_a_type() has correctly converted it to "-1" again to differentiate between pointer to struct from pointer to scalar variable. This differentiation is important to dump pointer to struct and pointer to scalar variable differently in ECPGdump_a_simple(). So, in ECPGdump_a_simple() we should dump the variable with arrsize "-1" if it's part of an outer structure.

--