Re: [HACKERS] Tuple sort is broken. It crashes on simple test.

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: [HACKERS] Tuple sort is broken. It crashes on simple test.
Дата
Msg-id CAFj8pRDYf2AqgCiaOb4eqNX4VkX6LjrYZn1fbWLO8uENCc-Cvw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] Tuple sort is broken. It crashes on simple test.  (Peter Geoghegan <pg@heroku.com>)
Ответы Re: [HACKERS] Tuple sort is broken. It crashes on simple test.  (Peter Geoghegan <pg@heroku.com>)
Список pgsql-hackers
Дерево обсуждения


2017-01-16 19:24 GMT+01:00 Peter Geoghegan <pg@heroku.com>:
On Mon, Jan 16, 2017 at 3:48 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Indeed. It crashes for me immediately by adding an ORDER BY:
> select count(distinct t) from seq_tab order by 1;

The problem was that one particular call to the macro
RELEASE_SLAB_SLOT() happened to lack a test-for-NULL-argument needed
by pass-by-value datum cases. The other two RELEASE_SLAB_SLOT() calls
already have such a check.

Attached patch fixes the bug.


Should not be enhanced regress tests too?

Regards

Pavel
 
--
Peter Geoghegan


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Geoghegan
Дата:
Сообщение: Re: [HACKERS] Tuple sort is broken. It crashes on simple test.
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: [HACKERS] Patch to implement pg_current_logfile() function