Re: [PROPOSAL] new diagnostic items for the dynamic sql

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: [PROPOSAL] new diagnostic items for the dynamic sql
Дата
Msg-id CAFj8pRDW-CWD8aJr7WV1KHPsMAF79_FA7FPe+6FJusf5cfZQCQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PROPOSAL] new diagnostic items for the dynamic sql  (Pavel Stehule <pavel.stehule@gmail.com>)
Ответы Re: [PROPOSAL] new diagnostic items for the dynamic sql  (Pavel Stehule <pavel.stehule@gmail.com>)
Список pgsql-hackers


po 8. 11. 2021 v 5:07 odesílatel Pavel Stehule <pavel.stehule@gmail.com> napsal:


+set_errcurrent_query (const char *query)

You can remove the space prior to (.
I wonder if the new field can be named current_err_query because that's what the setter implies.
current_query may give the impression that the field can store normal query (which doesn't cause exception).
The following code implies that only one of internalquery and current_query would be set.

yes, I think so current_query is not a good name too. Maybe query can be good enough - all in ErrorData is related to error

so the name of field can be query, and routine for setting errquery or set_errquery




+               if (estate->cur_error->internalquery)
+                   exec_assign_c_string(estate, var, estate->cur_error->internalquery);
+               else
+                   exec_assign_c_string(estate, var, estate->cur_error->current_query);

Cheers

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: removing global variable ThisTimeLineID
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: [PROPOSAL] new diagnostic items for the dynamic sql