On Fri, Nov 8, 2019 at 4:13 PM Pavel Stehule <pavel.stehule@gmail.com> wrote: > >>> Did you get a chance to look at the other related patch posted by me >>> [1]? I have asked it before as well because I think that need to go >>> before this. We need to avoid errors to happen after terminating the >>> connections as otherwise, the termination of other databases will go >>> be of no use. >>> >>> I have added the comment and changed one condition in tab-completion >>> as otherwise, it was allowing tab completion for the following syntax: >>> "drop database db1 , FORCE" which doesn't make sense to me. Please, >>> find the result attached. Let me know what you think? >>> >>> [1] - https://www.postgresql.org/message-id/CAA4eK1%2BqhLkCYG2oy9xug9ur_j%3DG2wQNRYAyd%2B-kZfZ1z42pLw%40mail.gmail.com >> >> >> I'll check it today > > > I checked it for 800 active clients, and it is working without problems. I run "check-world" without problem too. > > The patch looks well, I have not any comments. >
Thanks, but are you planning to look at the other thread mentioned in my previous email? We need to finish that before this.
I check it now - it has sense. the described switch can protect users against useless client killing.
The practical benefit will not be high, but it has sense and the code will more logic.