On 03/19/2014 04:34 PM, Pavel Stehule wrote: > Hello > > I wrote a few patches, that we use in our production. These patches > are small, but I hope, so its can be interesting for upstream: > > 1. cancel time - we log a execution time cancelled statements
+1
I even wrote a patch to do this, but it wasn't pretty so I never posted it. I would be happy to review yours or revive mine.
> 2. fatal verbose - this patch ensure a verbose log for fatal errors. > It simplify a investigation about reasons of error.
+0
> 3. relation limit - possibility to set session limit for maximum size > of relations. Any relation cannot be extended over this limit in > session, when this value is higher than zero. Motivation - we use lot > of queries like CREATE TABLE AS SELECT .. , and some very big results > decreased a disk free space too much. It was high risk in our multi > user environment. Motivation is similar like temp_files_limit.
-1
Also, I can't find any temp_files_limit setting anywhere.
any our server serves a about 100 users per seconds. We have system, that generate relative complex queries, where some Cartesian products are valid (although we are not happy). This limits removes a few (but real) critical issues, when we didn't enough free space on disc. After implementation of this limit we are able to ensure safe long time production with about 20% free space. In multiuser environment is more safe to kill some queries than lost your all production.
> 4. track statement lock - we are able to track a locking time for > query and print this data in slow query log and auto_explain log. It > help to us with lather slow query log analysis.
-0
> Do you thinking so these patches can be generally useful?