Re: proposal: multiple psql option -c

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: proposal: multiple psql option -c
Дата
Msg-id CAFj8pRCK7OLdrV3H3j2zaUQTb8NDc4GuDDzqfcOREAHyigkPWw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: proposal: multiple psql option -c  (Michael Paquier <michael.paquier@gmail.com>)
Ответы Re: proposal: multiple psql option -c  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-hackers


2015-11-30 15:17 GMT+01:00 Michael Paquier <michael.paquier@gmail.com>:
On Thu, Nov 26, 2015 at 4:21 AM, Pavel Stehule wrote:
> Attached patch per Tom Lane proposal.
>
> * multiple -c -f options are supported, the order of options is respected
> * the statements for one -c options are executed in transactions
> * Iacob's doc patch merged

 enum _actions
 {
        ACT_NOTHING = 0,
-       ACT_SINGLE_SLASH,
        ACT_LIST_DB,
-       ACT_SINGLE_QUERY,
-       ACT_FILE
+       ACT_FILE_STDIN
 };

Removing some items from the list of potential actions and creating a
new sublist listing action types is a bit weird. Why not grouping them
together and allow for example -l as well in the list of things that
is considered as a repeatable action? It seems to me that we could
simplify the code this way, and instead of ACT_NOTHING we could check
if the list of actions is empty or not.

fixed

Regards

Pavel
 
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Re: Error with index on unlogged table
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Error with index on unlogged table