Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE
Дата
Msg-id CAFj8pRBLq+JMzcwRVyGUiWHB+5tGhTr2wcbg+Ua0qPR38FBEAQ@mail.gmail.com
обсуждение исходный текст
Ответ на PoC: Make it possible to disallow WHERE-less UPDATE and DELETE  (David Fetter <david@fetter.org>)
Ответы Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATEand DELETE  (David Fetter <david@fetter.org>)
Список pgsql-hackers
Hi

2016-07-21 6:57 GMT+02:00 David Fetter <david@fetter.org>:
Folks,

Please find attached a patch which makes it possible to disallow
UPDATEs and DELETEs which lack a WHERE clause.  As this changes query
behavior, I've made the new GUCs PGC_SUSET.

What say?

Thanks to Gurjeet Singh for the idea and Andrew Gierth for the tips
implementing.


I am sending review of this patch

1. there are not any problem with patching, compiling, doc
2. the patch is simple, the documentation is good enough
3. all regress tests passed without problems

My questions:

1. is a data file really necessary? INSERT INTO test_require_where VALUES('aaa') has same effect.

2. There is not documented a assert "Assert(query->jointree != NULL)"

It is valid, but should be documented why?

Regards

Pavel
 
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: [HACKERS] parallelize queries containing subplans
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: [HACKERS] Commit fest 2017-01 will begin soon!