Re: proposal: possibility to read dumped table's name from file

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: proposal: possibility to read dumped table's name from file
Дата
Msg-id CAFj8pRB5KHVuUDb-FK+8wWWDLK9wbN2hYpcWhvnA3bx2m8Yciw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: proposal: possibility to read dumped table's name from file  (Daniel Gustafsson <daniel@yesql.se>)
Список pgsql-hackers
Дерево обсуждения
Hi


The above comments are fixed in the attached, as well as a pass over the docs
and extended tests to actually test matching a foreign server.  What do think
about this version?  I'm still not convinced that there aren't more quoting
bugs in the parser, but I've left that intact for now.

The problematic points are double quotes and new line char. Any other is just in  sequence of bytes.

I have just one note to your patch. When you use pg_strncasecmp, then you have to check the size too


    char       *xxx = "incl";
    int         xxx_size = 4;
   
elog(NOTICE, ">>>>%d<<<<",
      pg_strncasecmp(xxx, "include", xxx_size) == 0);

result is NOTICE:  >>>>1<<<<

"incl" is not keyword "include"

Regards

Pavel

 

--
Daniel Gustafsson               https://vmware.com/

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "蔡梦娟(玊于)"
Дата:
Сообщение: 回复：Queries that should be canceled will get stuck on secure_write function
Следующее
От: Robert Haas
Дата:
Сообщение: Re: extensible options syntax for replication parser?