Re: [HACKERS] Re: proposal - psql: possibility to specify sort fordescribe commands, when size is printed

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: [HACKERS] Re: proposal - psql: possibility to specify sort fordescribe commands, when size is printed
Дата
Msg-id CAFj8pRAqo98DygF04LWbeJtR+g=2OVr+WvFP4O2kw+JZru9JTw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] Re: proposal - psql: possibility to specify sort fordescribe commands, when size is printed  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Ответы Re: [HACKERS] Re: proposal - psql: possibility to specify sort fordescribe commands, when size is printed  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Re: [HACKERS] Re: proposal - psql: possibility to specify sort fordescribe commands, when size is printed  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Список pgsql-hackers
Дерево обсуждения
Hi

2017-09-19 16:14 GMT+02:00 Alexander Korotkov <a.korotkov@postgrespro.ru>:
On Fri, Sep 8, 2017 at 7:13 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
2017-08-16 14:06 GMT+02:00 Pavel Stehule <pavel.stehule@gmail.com>:
Hi

2017-08-15 4:37 GMT+02:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:
On 3/11/17 07:06, Pavel Stehule wrote:
> I am sending a updated version with separated sort direction in special
> variable

This patch also needs a rebase.

I am sending rebased patch

rebased again + fix obsolete help

For me, patch applies cleanly, builds and passed regression tests.
However, patch misses regression tests covering added functionality.

I am not sure if there are any tests related to output of \dt+ commands - there result is platform depend.
 
Patch is definitely harmless, i.e. it doesn't affect anybody who doesn't use new functionality.
But I still would prefer ordering to be options of \d* commands while psql variables be defaults for those options...

I understand

a) I don't think so commands like \dt++ (or similar) is good idea - these commands should be simple how it is possible

b) this patch doesn't block any other design - more it opens the door because the executive part will be implemented and users can have a experience with with different output sorts - so if people will need more quick change of result sort, then the work in this area will continue.

Regards

Pavel







------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: [HACKERS] Re: [COMMITTERS] pgsql: Perform only oneReadControlFile() during startup.
Следующее
От: chiru r
Дата:
Сообщение: [HACKERS] USER Profiles for PostgreSQL