Re: PATCH: pgbench allow '=' in \set

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: PATCH: pgbench allow '=' in \set
Дата
Msg-id CAFj8pRAnzWezEufM67qNESFAi=7y0NeK5Rpn_2k5=hs73jg=PQ@mail.gmail.com
обсуждение исходный текст
Ответ на PATCH: pgbench allow '=' in \set  (Fabien COELHO <coelho@cri.ensmp.fr>)
Ответы Re: PATCH: pgbench allow '=' in \set  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: PATCH: pgbench allow '=' in \set  (Fabien COELHO <coelho@cri.ensmp.fr>)
Список pgsql-hackers


2015-05-07 20:18 GMT+02:00 Fabien COELHO <coelho@cri.ensmp.fr>:

Hello devs,

Since an expression syntax has been added to pgbench, I find that the readability of expressions is not great. An extra '=' improves the situation for me:

   \set id = 1 + abs((:id * 1021) % (100000 * :scale))

seems slightly better than:

   \set id 1 + abs((:id * 1021) % (100000 * :scale))

But that is debatable!

The attached patch just ignores a leading '=' in a pgbench expression.

It is question :( - it break a consistency with psql

Regards

Pavel
 

--
Fabien.


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: EvalPlanQual behaves oddly for FDW queries involving system columns
Следующее
От: Andres Freund
Дата:
Сообщение: Re: INSERT ... ON CONFLICT error messages