On 2019-03-22 01:21, Amit Langote wrote: > On 2019/03/22 2:23, David Steele wrote: >> On 3/14/19 6:19 AM, Amit Langote wrote: >>> On 2019/03/14 2:11, Pavel Stehule wrote: >>>> >>>>> I've attached v11 of the patch, which merges most of Justin's changes and >>>>> some of my own on top -- documentation and partition size column names. >>> >>> Maybe, we should set this ready for committer then? >> >> There don't appear to be any objections. Perhaps you should do that? > > OK, done.
What is the purpose of this patch (hint: commit message)? The email subject is "show size of partitioned table", which seems reasonable, but looking briefly at a patch, it adds new psql commands to display partitioned tables only. I don't understand the purpose of that.
When I started with this patch, main goal was displaying total size of partitioned tables (sum of size of partitions).
Now, this it can show more - size of indexes, data, - it can aggregate per partitions levels.
(Moreover, who is the author of this patch? Is the commit fest entry accurate?)
I am a author, but lot of peoples did modifications and comments.
Regards
Pavel
-- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services