On Sat, Jan 7, 2023 at 11:13 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> On Saturday, January 7, 2023 12:50 PM Dilip Kumar <dilipbalaut@gmail.com>
> >
> > On Fri, Jan 6, 2023 at 3:38 PM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com>
> > wrote:
> > >
> >
> > Looks good, but I feel in pa_process_spooled_messages_if_required()
> > function after getting the filestate the first check should be if (filestate==
> > FS_EMPTY) return false. I mean why to process through all the states if it is
> > empty and we can directly exit. It is not a big deal so if you prefer the way it is
> > then I have no objection to it.
>
> I think your suggestion looks good, I have adjusted the code.
> I also rebase the patch set due to the recent commit c6e1f6.
> And here is the new version patch set.
>
LGTM
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com