Re: Patch for RM1720 [pgadmin4]
От | Harshal Dhumal |
---|---|
Тема | Re: Patch for RM1720 [pgadmin4] |
Дата | |
Msg-id | CAFiP3vzHwXrdJ0A8A6K4VqYutH+So3xcvFVxsiSk6SGH7M2Zrg@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Patch for RM1720 [pgadmin4] (Dave Page <dpage@pgadmin.org>) |
Ответы |
Re: Patch for RM1720 [pgadmin4]
|
Список | pgadmin-hackers |
Hi,
Please find attached updated patch for RM1720.--
Harshal Dhumal
Software Engineer
On Wed, Sep 21, 2016 at 8:39 PM, Dave Page <dpage@pgadmin.org> wrote:
On Wed, Sep 21, 2016 at 4:02 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
> Can you please run testsuite for server or database node only, as
> there are some code modifications are remaining on the rest of the nodes.
> Currently i don't have a machine to look into issue, will check it tomorrow.
OK, here's the result:
(pgadmin4)piranha:web dpage$ python regression/runtests.py --pkg
browser.server_groups.servers.databases
pgAdmin 4 - Application Initialisation
======================================
The configuration database - '/Users/dpage/.pgadmin/test_pgadmin4.db'
does not exist.
Entering initial setup mode...
NOTE: Configuring authentication for SERVER mode.
The configuration database has been created at
/Users/dpage/.pgadmin/test_pgadmin4.db
=============Running the test cases for 'Regression - PG 9.4'=============
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_add. DatabaseAddTestCase)
This function will add database under 1st server of tree node. (Check
Databases Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_delete. DatabaseDeleteTestCase)
This function will delete the database. (Check Databases Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_get. DatabasesGetTestCase)
This function will fetch added database. (Check Databases Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_put. DatabasesUpdateTestCase)
This function will update the comments field of database. (Check
Databases Node) ... ok
------------------------------------------------------------ ----------
Ran 4 tests in 1.310s
OK
=============Running the test cases for 'Regression - PG 9.5'=============
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_add. DatabaseAddTestCase)
This function will add database under 1st server of tree node. (Check
Databases Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_delete. DatabaseDeleteTestCase)
This function will delete the database. (Check Databases Node URL) ... FAIL
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_get. DatabasesGetTestCase)
This function will fetch added database. (Check Databases Node URL) ... ERROR
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_put. DatabasesUpdateTestCase)
This function will update the comments field of database. (Check
Databases Node) ... ERRORRan 4 tests in 1.019s============================================================ ==========
ERROR: runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_get. DatabasesGetTestCase)
This function will fetch added database. (Check Databases Node URL)
------------------------------------------------------------ ----------
Traceback (most recent call last):
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/ tests/test_db_get.py",
line 33, in runTest
self.db_id)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/ tests/utils.py",
line 142, in verify_database
follow_redirects=True)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 788, in post
return self.open(*args, **kw)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/testing.py",
line 113, in open
follow_redirects=follow_redirects)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 751, in open
response = self.run_wsgi_app(environ, buffered=buffered)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 668, in run_wsgi_app
rv = run_wsgi_app(self.application, environ, buffered=buffered)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 871, in run_wsgi_app
app_rv = app(environ, start_response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 2000, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1625, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/views.py",
line 84, in view
return self.dispatch_request(*args, **kwargs)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line
235, in dispatch_request
return method(*args, **kwargs)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/__ init__.py",
line 364, in connect
conn = manager.connection(did=did, auto_reconnect=True)
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/ psycopg2/__init__.py",
line 1448, in connection
"Couldn't find the specified database."
Exception: Couldn't find the specified database.
============================================================ ==========
ERROR: runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_put. DatabasesUpdateTestCase)
This function will update the comments field of database. (Check Databases Node)
------------------------------------------------------------ ----------
Traceback (most recent call last):
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/ tests/test_db_put.py",
line 37, in runTest
db_id)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/ tests/utils.py",
line 142, in verify_database
follow_redirects=True)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 788, in post
return self.open(*args, **kw)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/testing.py",
line 113, in open
follow_redirects=follow_redirects)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 751, in open
response = self.run_wsgi_app(environ, buffered=buffered)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 668, in run_wsgi_app
rv = run_wsgi_app(self.application, environ, buffered=buffered)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 871, in run_wsgi_app
app_rv = app(environ, start_response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 2000, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1625, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/views.py",
line 84, in view
return self.dispatch_request(*args, **kwargs)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line
235, in dispatch_request
return method(*args, **kwargs)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/__ init__.py",
line 364, in connect
conn = manager.connection(did=did, auto_reconnect=True)
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/ psycopg2/__init__.py",
line 1448, in connection
"Couldn't find the specified database."
Exception: Couldn't find the specified database.
============================================================ ==========
FAIL: runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_delete. DatabaseDeleteTestCase)
This function will delete the database. (Check Databases Node URL)
------------------------------------------------------------ ----------
Traceback (most recent call last):
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/ tests/test_db_delete.py",
line 38, in runTest
self.assertEquals(response.status_code, 200)
AssertionError: 410 != 200
------------------------------------------------------------ ----------
FAILED (failures=1, errors=2)
=============Running the test cases for 'Regression - EPAS 9.5'=============
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_add. DatabaseAddTestCase)
This function will add database under 1st server of tree node. (Check
Databases Node URL) ... ok
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_delete. DatabaseDeleteTestCase)
This function will delete the database. (Check Databases Node URL) ... FAIL
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_get. DatabasesGetTestCase)
This function will fetch added database. (Check Databases Node URL) ... ERROR
runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_put. DatabasesUpdateTestCase)
This function will update the comments field of database. (Check
Databases Node) ... ERRORRan 4 tests in 1.807s============================================================ ==========
ERROR: runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_get. DatabasesGetTestCase)
This function will fetch added database. (Check Databases Node URL)
------------------------------------------------------------ ----------
Traceback (most recent call last):
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/ tests/test_db_get.py",
line 33, in runTest
self.db_id)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/ tests/utils.py",
line 142, in verify_database
follow_redirects=True)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 788, in post
return self.open(*args, **kw)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/testing.py",
line 113, in open
follow_redirects=follow_redirects)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 751, in open
response = self.run_wsgi_app(environ, buffered=buffered)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 668, in run_wsgi_app
rv = run_wsgi_app(self.application, environ, buffered=buffered)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 871, in run_wsgi_app
app_rv = app(environ, start_response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 2000, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1625, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/views.py",
line 84, in view
return self.dispatch_request(*args, **kwargs)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line
235, in dispatch_request
return method(*args, **kwargs)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/__ init__.py",
line 364, in connect
conn = manager.connection(did=did, auto_reconnect=True)
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/ psycopg2/__init__.py",
line 1448, in connection
"Couldn't find the specified database."
Exception: Couldn't find the specified database.
============================================================ ==========
ERROR: runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_put. DatabasesUpdateTestCase)
This function will update the comments field of database. (Check Databases Node)
------------------------------------------------------------ ----------
Traceback (most recent call last):
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/ tests/test_db_put.py",
line 37, in runTest
db_id)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/ tests/utils.py",
line 142, in verify_database
follow_redirects=True)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 788, in post
return self.open(*args, **kw)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/testing.py",
line 113, in open
follow_redirects=follow_redirects)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 751, in open
response = self.run_wsgi_app(environ, buffered=buffered)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 668, in run_wsgi_app
rv = run_wsgi_app(self.application, environ, buffered=buffered)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/werkzeug/test.py",
line 871, in run_wsgi_app
app_rv = app(environ, start_response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 2000, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/app.py",
line 1625, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- packages/flask/views.py",
line 84, in view
return self.dispatch_request(*args, **kwargs)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line
235, in dispatch_request
return method(*args, **kwargs)
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/__ init__.py",
line 364, in connect
conn = manager.connection(did=did, auto_reconnect=True)
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/ psycopg2/__init__.py",
line 1448, in connection
"Couldn't find the specified database."
Exception: Couldn't find the specified database.
============================================================ ==========
FAIL: runTest (pgadmin.browser.server_groups.servers.databases. tests.test_db_delete. DatabaseDeleteTestCase)
This function will delete the database. (Check Databases Node URL)
------------------------------------------------------------ ----------
Traceback (most recent call last):
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/databases/ tests/test_db_delete.py",
line 38, in runTest
self.assertEquals(response.status_code, 200)
AssertionError: 410 != 200
------------------------------------------------------------ ----------
FAILED (failures=1, errors=2)
Test Result Summary
============================
Regression - EPAS 9.5: 1 test passed, 3 tests failed :
DatabaseDeleteTestCase
DatabasesGetTestCase
DatabasesUpdateTestCase
Regression - PG 9.5: 1 test passed, 3 tests failed :
DatabaseDeleteTestCase
DatabasesGetTestCase
DatabasesUpdateTestCase
Regression - PG 9.4: 4 tests passed, 0 tests failed============================
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
В списке pgadmin-hackers по дате отправления:
Следующее
От: Murtuza ZabuawalaДата:
Сообщение: PATCH: To fix the issue with stats table in PG9.6 (pgAdmin4)