Re: Sequence Access Method WIP

<div dir="ltr"><div class="gmail_extra"><br />On Tue, Mar 29, 2016 at 2:26 PM, Petr Jelinek <<a
href="mailto:petr@2ndquadrant.com">petr@2ndquadrant.com</a>>wrote:<br />><br />> On 29/03/16 18:50, Fabrízio
deRoyes Mello wrote:<br />>><br />>><br />>><br />>> On Tue, Mar 29, 2016 at 12:25 PM, David
Steele<<a href="mailto:david@pgmasters.net">david@pgmasters.net</a><br />>> <mailto:<a
href="mailto:david@pgmasters.net">david@pgmasters.net</a>>>wrote:<br />>>  ><br />>>  > Hi
Petr,<br/>>>  ><br />>>  > On 3/28/16 3:11 PM, Fabrízio de Royes Mello wrote:<br />>>  ><br
/>>> >> fabrizio@bagual:~/pgsql<br />>>  >> $ bin/pg_dump > /tmp/fabrizio.sql<br />>>
 >>pg_dump: [archiver (db)] query failed: ERROR:  column "sequence_name"<br />>>  >> does not
exist<br/>>>  >> LINE 1: SELECT sequence_name, start_value, increment_by, CASE WHEN i...<br />>>
 >>                ^<br />>>  >> pg_dump: [archiver (db)] query was: SELECT sequence_name,
start_value,<br/>>>  >> increment_by, CASE WHEN increment_by > 0 AND max_value =<br />>>  >>
9223372036854775807THEN NULL      WHEN increment_by < 0 AND max_value =<br />>>  >> -1 THEN NULL    
 ELSEmax_value END AS max_value, CASE WHEN<br />>>  >> increment_by > 0 AND min_value = 1 THEN NULL    
 WHENincrement_by < 0<br />>>  >> AND min_value = -9223372036854775807 THEN NULL      ELSE min_value
END<br/>>>  >> AS min_value, cache_value, is_cycled FROM x<br />>>  ><br />>>  ><br
/>>> > It looks like a new patch is needed.  I've marked this "waiting on<br />>> author".<br />>>
 ><br/>>><br />><br />> Yeah there were some incompatible commits since my last rebase, fixed, along
withthe pg_dump bugs..<br />><br /><br /></div><div class="gmail_extra">Now all applies without errors, build and
"makecheck" too.<br /></div><div class="gmail_extra"><br /><br /><br />>> But there are other issue in the
gapless-seqextension when I ran "make<br />>> check":<br />>><br />>>   43   CREATE EXTENSION
gapless_seq;<br/>>>   44   CREATE SEQUENCE test_gapless USING gapless;<br />>>   45   SELECT
nextval('test_gapless'::regclass);<br/>>>   46 ! ERROR:  could not access status of transaction 1275068416<br
/>>>  47 ! DETAIL:  Could not open file "pg_subtrans/4C00": No such file or<br />>> directory.<br
/>>>  48   BEGIN;<br />>>   49     SELECT nextval('test_gapless'::regclass);<br />>>   50 ! ERROR:
 couldnot access status of transaction 1275068416<br />>>   51 ! DETAIL:  Could not open file "pg_subtrans/4C00":
Nosuch file or<br />>> directory.<br />>>   52     SELECT nextval('test_gapless'::regclass);<br />>>
 53 ! ERROR:  current transaction is aborted, commands ignored until<br />>> end of transaction block<br
/>>>  54     SELECT nextval('test_gapless'::regclass);<br />>>   55 ! ERROR:  current transaction is
aborted,commands ignored until<br />>> end of transaction block<br />>>   56   ROLLBACK;<br />>>   57
 SELECT nextval('test_gapless'::regclass);<br />>>   58 ! ERROR:  could not access status of transaction
1275068416<br/>>>   59 ! DETAIL:  Could not open file "pg_subtrans/4C00": No such file or<br />>>
directory.<br/>>><br />>><br />>> And I see the same running manually:<br />>><br />>>
fabrizio=#create extension gapless_seq;<br />>> CREATE EXTENSION<br />>> fabrizio=# create sequence x using
gapless;<br/>>> CREATE SEQUENCE<br />>> fabrizio=# select nextval('x');<br />>> ERROR:  could not
accessstatus of transaction 1258291200<br />>> DETAIL:  Could not open file "pg_subtrans/4B00": No such file or
directory.<br/>>><br />>> Regards,<br />>><br />><br />> Hmm I am unable to reproduce this.
WhatOS? Any special configure flags you use?<br />><br /><br /></div><div class="gmail_extra">In my environment the
errorremains with your last patches. <br /><br />I didn't use any special. <br /><br />./configure
--prefix=/home/fabrizio/pgsql--enable-cassert --enable-coverage --enable-tap-tests --enable-depend <br /></div><div
class="gmail_extra">make-s -j8 install<br /></div><div class="gmail_extra">make check-world<br /></div><div
class="gmail_extra"><br/><br /></div><div class="gmail_extra">My environment:<br /></div><div class="gmail_extra"><br
/>fabrizio@bagual:/d/postgresql(0002-gapless-seq-petr) <br />$ uname -a<br />Linux bagual 3.13.0-83-generic #127-Ubuntu
SMPFri Mar 11 00:25:37 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux<br /><br />fabrizio@bagual:/d/postgresql
(0002-gapless-seq-petr)<br />$ gcc --version<br />gcc (Ubuntu 4.8.4-2ubuntu1~14.04.1) 4.8.4<br />Copyright (C) 2013
FreeSoftware Foundation, Inc.<br />This is free software; see the source for copying conditions.  There is NO<br
/>warranty;not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.<br /><br /><br /></div><div
class="gmail_extra">Regards,<br/></div><div class="gmail_extra"><br />--<br />Fabrízio de Royes Mello<br
/>Consultoria/CoachingPostgreSQL<br />>> Timbira: <a
href="http://www.timbira.com.br">http://www.timbira.com.br</a><br/>>> Blog: <a
href="http://fabriziomello.github.io">http://fabriziomello.github.io</a><br/>>> Linkedin: <a
href="http://br.linkedin.com/in/fabriziomello">http://br.linkedin.com/in/fabriziomello</a><br/>>> Twitter: <a
href="http://twitter.com/fabriziomello">http://twitter.com/fabriziomello</a><br/>>> Github: <a
href="http://github.com/fabriziomello">http://github.com/fabriziomello</a></div></div>