Re: Use PqMsg_* macros in basebackup_copy.c
| От | Fabrízio de Royes Mello |
|---|---|
| Тема | Re: Use PqMsg_* macros in basebackup_copy.c |
| Дата | |
| Msg-id | CAFcNs+pY+u2q_uDf63S1+8JWSz5JGcc3q2irFM9Gi49Q0X=pCg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Use PqMsg_* macros in basebackup_copy.c (Nathan Bossart <nathandbossart@gmail.com>) |
| Список | pgsql-hackers |
On Fri, Jul 25, 2025 at 12:34 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Fri, Jul 25, 2025 at 11:47:52AM -0300, Fabrízio de Royes Mello wrote:
> > Attached patch for $SUBJECT.
>
> Could we move this to the existing thread on the topic [0]? I see one more
> CopyData character in this file, plus some others that probably need their
> own characters in protocol.h:
>
Absolutely
> ./basebackup_copy.c:146: mysink->msgbuffer[0] = 'd'; /* archive or manifest data */
Missed that one.
> ./basebackup_copy.c:173: pq_sendbyte(&buf, 'n'); /* New archive */
> ./basebackup_copy.c:224: pq_sendbyte(&buf, 'p'); /* Progress report */
> ./basebackup_copy.c:250: pq_sendbyte(&buf, 'p'); /* Progress report */
> ./basebackup_copy.c:265: pq_sendbyte(&buf, 'm'); /* Manifest */
>
Was doing a separate patch but agreed to do everything in the same thread/patch.
Regards,
> ./basebackup_copy.c:224: pq_sendbyte(&buf, 'p'); /* Progress report */
> ./basebackup_copy.c:250: pq_sendbyte(&buf, 'p'); /* Progress report */
> ./basebackup_copy.c:265: pq_sendbyte(&buf, 'm'); /* Manifest */
>
Was doing a separate patch but agreed to do everything in the same thread/patch.
Regards,
--
Fabrízio de Royes Mello
В списке pgsql-hackers по дате отправления: