Re: NOT EXIST for PREPARE

<div dir="ltr"><div class="gmail_extra">On Tue, Mar 22, 2016 at 6:04 PM, Yury Zhuravlev <<a
href="mailto:u.zhuravlev@postgrespro.ru">u.zhuravlev@postgrespro.ru</a>>wrote:<br />><br />> I was not sure
aboutthe syntax, so this was a prototype. Now, like all completed yet.<br />><br />>><br />>> 1) I think
thissyntax is wrong... Instead the common should be:<br />>><br />>> PREPARE [IF NOT EXISTS] ...<br
/>><br/>> You right. Done.<br />><br />><br />>> 2) All of CINE statements we emit a NOTICE skipping
message,so you should<br />>> emit a message like it:<br />><br />> Done.<br />><br />><br />>>
3)There are no regression tests<br />><br />> Done.<br />>><br />>> 4) There are no docs<br />><br
/>>Done.<br />><br /><br /></div><div class="gmail_extra">I got an error when build this patch.<br /><br />$
./configure--prefix=/home/fabrizio/pgsql --enable-cassert --enable-coverage --enable-tap-tests --enable-depend<br /><br
/>...<br/><br /></div><div class="gmail_extra">$ make<br /><br />...<br />gcc -Wall -Wmissing-prototypes
-Wpointer-arith-Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security
-fno-strict-aliasing-fwrapv -fexcess-precision=standard -fprofile-arcs -ftest-coverage  -pthread -D_REENTRANT
-D_THREAD_SAFE-D_POSIX_PTHREAD_SEMANTICS -DECPG_COMPILE -I../include -I../../../../src/interfaces/ecpg/include -I. -I.
-DMAJOR_VERSION=4-DMINOR_VERSION=12 -DPATCHLEVEL=0 -I../../../../src/include -D_GNU_SOURCE   -c -o preproc.o preproc.c
-MMD-MP -MF .deps/preproc.Po<br />preproc.y: In function ‘base_yyparse’:<br />preproc.y:8654:15: error: incompatible
typeswhen assigning to type ‘struct prep’ from type ‘char *’<br />  $$ = cat_str(5,mm_strdup("prepare if not
exists"),$5,$6,mm_strdup("as"),$8);<br/>               ^<br />make[4]: *** [preproc.o] Error 1<br />make[4]: Leaving
directory`/data/fabrizio/Dropbox/dev/postgresql/src/interfaces/ecpg/preproc'<br />make[3]: *** [all-preproc-recurse]
Error2<br />make[3]: Leaving directory `/data/fabrizio/Dropbox/dev/postgresql/src/interfaces/ecpg'<br />make[2]: ***
[all-ecpg-recurse]Error 2<br />make[2]: Leaving directory `/data/fabrizio/Dropbox/dev/postgresql/src/interfaces'<br
/>make[1]:*** [all-interfaces-recurse] Error 2<br />make[1]: Leaving directory
`/data/fabrizio/Dropbox/dev/postgresql/src'<br/>make: *** [all-src-recurse] Error 2<br /><br /><br /></div><div
class="gmail_extra"><br/></div><div class="gmail_extra">I also didin't see no psql tab-complete code.<br /></div><div
class="gmail_extra"><br/><br />Regards,<br /></div><div class="gmail_extra"><br />--<br />Fabrízio de Royes Mello<br
/>Consultoria/CoachingPostgreSQL<br />>> Timbira: <a
href="http://www.timbira.com.br">http://www.timbira.com.br</a><br/>>> Blog: <a
href="http://fabriziomello.github.io">http://fabriziomello.github.io</a><br/>>> Linkedin: <a
href="http://br.linkedin.com/in/fabriziomello">http://br.linkedin.com/in/fabriziomello</a><br/>>> Twitter: <a
href="http://twitter.com/fabriziomello">http://twitter.com/fabriziomello</a><br/>>> Github: <a
href="http://github.com/fabriziomello">http://github.com/fabriziomello</a></div></div>