Re: Support for array_remove and array_replace functions

Поиск
Список
Период
Сортировка
От Alex Hunsaker
Тема Re: Support for array_remove and array_replace functions
Дата
Msg-id CAFaPBrTo4_qKcFWFg4nTPupAFPdWR_t6e2Jv3RWagi-k-QLziQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Support for array_remove and array_replace functions  (Marco Nenciarini <marco.nenciarini@2ndquadrant.it>)
Список pgsql-hackers
On Sat, Jun 30, 2012 at 3:28 PM, Marco Nenciarini
<marco.nenciarini@2ndquadrant.it> wrote:
>
> On 30/06/2012 04:16, Alex Hunsaker wrote:
> >
> > Hi, I've been reviewing this patch.
> >
> > Good documentation, and regression tests. The code looked fine but I
> > didn't care for the code duplication between array_replace and
> > array_remove so I merged those into a helper function,
> > array_replace_internal(). Thoughts?
>
> It looks reasonable.
>
> There was a typo in array_replace which was caught by regression tests.
> I've fixed the typo and changed a comment in array_replace_internal.
>
> Patch v3 attached.

Looks good to me, marked ready for commiter.


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Hans-Jürgen Schönig
Дата:
Сообщение: Re: [PATCH] Make pg_basebackup configure and start standby
Следующее
От: Tom Lane
Дата:
Сообщение: Re: XX000: enum value 117721 not found in cache for enum enumcrash