On Thu, May 24, 2012 at 11:19 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> clang warns about that newish SvREFCNT_inc(sv) call in plperl_helpers.h
> about an unused return value, because the macro expansion of
> SvREFCNT_inc(sv) returns sv. The merit of that warning might be
> debatable, but it seems easy to fix by using SvREFCNT_inc_void(sv)
> instead.
>
> And we could use SvREFCNT_inc_simple_void(sv), since sv doesn't have any
> side effects, but that's optional.
>
> Any concerns?
Hrm I can't seem to find either of those functions in my copy of perl
5.8.1 or 5.16.0. I also looked for "_inc_" in the event I got casing
wrong :-(.
Perhaps I misunderstood, are you proposing to introduce those
functions? Im fine with that. Or doing (void)SvREFCNT_inc().