On Mon, Mar 17, 2025 at 8:26 PM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> > > I was referring to the discussion upthread [1]; you'd mentioned that
> > > the only reason that get_connect_string() didn't call GetUserMapping()
> > > itself was because we needed that mapping later on for
> > > UseScramPassthrough(). But that's no longer true for this patch,
> > > because the later call to UseScramPassthrough() has been removed. So I
> > > think we can move GetUserMapping() back down, and remove that part of
> > > the refactoring from patch 0001.
> > >
> > Ok, it totally makes sense. Fixed on v7.
>
> The fix is in, but it needs to be part of 0001 rather than 0002;
> otherwise 0001 doesn't compile.
>
Fixed. 0001 and 0002 are compiling now.
> --
>
> A pgperltidy run is needed for some of the more recent test changes.
> But I'm rapidly running out of feedback, so I think this is very
> close.
>
Fixed
Thanks very much for all the reviews on this patch!
--
Matheus Alcantara