Re: [GSoC] Finalized First Patch

Поиск
Список
Период
Сортировка
От Yosry Muhammad
Тема Re: [GSoC] Finalized First Patch
Дата
Msg-id CAFSMqn_gEi1JyeHdeFqWKtjg9w4T8p7Edi8iKPEtX1_qZjo0Fg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [GSoC] Finalized First Patch  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [GSoC] Finalized First Patch  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Hi,

On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Some points I missed:
1.  I assumed that in this patch modification in case of OIDs= True (without primary key) has not considered as that is not working.

This is not implemented yet. I will work on that in a following patch soon enough.

2. As we are already showing the changed Data prompt on closing the Query Tool, do we really need the Uncommitted Transaction prompt? 

This is needed when auto-commit is off. Saving changes in the data grid is performed as part of the ongoing transaction (or a new one if none is ongoing). After saving the data changes the user should still commit the current transaction for the changes to be commited to the database. This feature is also useful in general when auto-commit is off as users may forget to commit ongoing transactions.

Thanks and Regards :D

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Yosry Muhammad
Дата:
Сообщение: Re: [GSoC] Finalized First Patch
Следующее
От: Akshay Joshi
Дата:
Сообщение: [pgAdmin4][Patch]: RM 4452 Add RE-SQL tests for Languages