[pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

Поиск
Список
Период
Сортировка
От Matthew Kleiman
Тема [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question
Дата
Msg-id CAFS4TJb-7VTQQrnOi0g6MaoxMfEK9LzCds2yG+ByS-mLHwydQA@mail.gmail.com
обсуждение исходный текст
Ответы Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
Hi Hackers!

We noticed that there have been quite a few Redmine issues that ended up being related to the same function in sqleditor.js. We were wondering if it might be a good idea to extract this function and test it. This would allow us to iterate more quickly and identify potential bugs before they're opened. There have been a few merge conflicts already in this area and without tests it is difficult to resolve these with high confidence. 

The function in question is the callback for onSelectedRangesChanged. In the latest commit on master (12fa02), it's from line 696 to 773.

Inline image 1

Thoughts?

Best,
Sarah & Matt
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Murtuza Zabuawala
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.
Следующее
От: Robert Eckhardt
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query ResultsGrid User Experience