Re: Skip collecting decoded changes of already-aborted transactions

Поиск
Список
Период
Сортировка
От Ajin Cherian
Тема Re: Skip collecting decoded changes of already-aborted transactions
Дата
Msg-id CAFPTHDZ=EA7VpjrWa0wMcXhubuOM82-g1b-0d5JZF2FjzLtDrQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Skip collecting decoded changes of already-aborted transactions  (Masahiko Sawada <sawada.mshk@gmail.com>)
Ответы Re: Skip collecting decoded changes of already-aborted transactions
Список pgsql-hackers
Дерево обсуждения


On Mon, Mar 18, 2024 at 7:50 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:

In addition to these changes, I've made some changes to the latest
patch. Here is the summary:

- Use txn_flags field to record the transaction status instead of two
'committed' and 'aborted' flags.
- Add regression tests.
- Update commit message.

Regards,


Hi Sawada-san,

Thanks for the updated patch. Some comments:

1.
+ * already aborted, we discards all changes accumulated so far and ignore
+ * future changes, and return true. Otherwise return false.

we discards/we discard

2. In function ReorderBufferCheckTXNAbort(): I haven't tested this but I wonder how prepared transactions would be considered, they are neither committed, nor in progress.

regards,
Ajin Cherian
Fujitsu Australia

В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: Flushing large data immediately in pqcomm
Следующее
От: Masahiko Sawada
Дата:
Сообщение: Re: Skip collecting decoded changes of already-aborted transactions