On Wed, Jun 9, 2021 at 6:23 AM Jeff Davis <pgsql@j-davis.com> wrote:
>
> On Tue, 2021-06-08 at 17:41 +1000, Ajin Cherian wrote:
> > Here's an updated patchset that adds back in the option for two-phase
> > in CREATE_REPLICATION_SLOT command and a second patch that adds
> > support for
> > two-phase decoding in pg_recvlogical.
>
> A few things:
>
> * I suggest putting the TWO_PHASE keyword after the LOGICAL keyword
> * Document the TWO_PHASE keyword in doc/src/sgml/protocol.sgml
> * Cross check that --two-phase is specified only if --create-slot is
> specified
> * Maybe an Assert(!(two_phase && is_physical)) in
> CreateReplicationSlot()?
>
> Other than that, it looks good, and it works as I expect it to.
Updated. Do have a look.
thanks,
Ajin Cherian
Fujitsu Australia