Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

Поиск
Список
Период
Сортировка
От Khushboo Vashi
Тема Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell
Дата
Msg-id CAFOhELdPrasPKUJOrME6xL2L5htHtP-024nhm6MWDqPcdu9vtA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Hi Harshal,

The Selec2Cell and PrivilegeCell are working properly but I think we should also consider below:

1. The Backgrid and sub-node should have accessibility including every button, cell and control.
2. The Backgrid table header is accessible through keyboard but it should be highlighted when it gets focus.

@Akshay, we can commit this patch but we should create the separate RM for above fixes.

Thanks,
Khushboo


On Mon, Jan 21, 2019 at 4:40 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo 

Can you please review it.

On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Please find attached patch to fix backgrid navigation using keyboard
for Select2Cell and PrivilegeCell

-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working
Следующее
От: Khushboo Vashi
Дата:
Сообщение: Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for createscript of domain type interval with precision. ERROR: syntax error at or near "["