John Naylor <john.naylor@enterprisedb.com> writes: > I noticed that the table AM abstraction introduced the symbol > HEAP_TABLE_AM_HANDLER_OID, although we already have a convention for > defining symbols automatically for builtin functions, which in this case is > (currently unused) F_HEAP_TABLEAM_HANDLER.
Yeah, that seems wrong. I'd just remove HEAP_TABLE_AM_HANDLER_OID. As long as we're not back-patching the change, it seems like a very minor thing to fix, if anyone outside core is referencing the old name.
Ok, here is a patch to fix that, and also throw an error if pg_proc.dat has an explicitly defined symbol.