Re: CREATE SEQUENCE with RESTART option

Поиск

Список

Период

Сортировка

От	Suraj Kharage
Тема	Re: CREATE SEQUENCE with RESTART option
Дата	8 апреля 2021 г. 12:46:26
Msg-id	CAF1DzPW1joY-d44yvKddBAGEVp7LOtp-hjO8FuPu0f30eQhqYA@mail.gmail.com обсуждение исходный текст
Ответ на	Re: CREATE SEQUENCE with RESTART option (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Ответы	Re: CREATE SEQUENCE with RESTART option
Список	pgsql-hackers

Дерево обсуждения

On Thu, Apr 8, 2021 at 2:03 PM Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:

>
> The RESTART clause in the CREATE SEQUENCE doesn't make sense
> to me, it should be restricted, IMO.

Thanks! Attaching a patch that throws an error if the RESTART option
is specified with CREATE SEQUENCE. Please have a look and let me know
if the error message wording is fine or not. Is it better to include
the reason as to why we disallow something like "Because it may
override the START option." in err_detail along with the error
message?

Patch looks good to me. Current error message looks ok to me.

Do we need to add double quotes for RESTART word in the error message since it is an option?

Thanks & Regards,

Suraj kharage,