Re: Potential memory leak in contrib/intarray's g_intbig_compress

Поиск
Список
Период
Сортировка
От Matthias van de Meent
Тема Re: Potential memory leak in contrib/intarray's g_intbig_compress
Дата
Msg-id CAEze2Wjm_Zb=WV8VJFOdszrUGbC3kfVTRE2=ty5iAYkyhJukYw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Potential memory leak in contrib/intarray's g_intbig_compress  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Fri, 14 Jul 2023 at 07:57, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Jul 13, 2023 at 06:28:39PM +0200, Matthias van de Meent wrote:
> > There are similar pfree calls in the _int_gist.c file's g_int_compress
> > function, which made me think we do need to clean up after use, but
> > indeed these pfrees are useless (or even harmful if bug #17888 can be
> > trusted)
>
> Indeed, all these are in a GiST temporary context.  So you'd mean
> something like the attached perhaps, for both the decompress and
> compress paths?

Yes, looks good to me. Thanks!

Kind regards,

Matthias van de Meent
Neon (https://neon.tech)



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Richard Guo
Дата:
Сообщение: Re: Oversight in reparameterize_path_by_child leading to executor crash
Следующее
От: Melih Mutlu
Дата:
Сообщение: Re: Adding a LogicalRepWorker type field