On Wed, Apr 2, 2025 at 1:00 PM Amit Langote <amitlangote09@gmail.com> wrote:
>
> I'm feeling good about this version, but let me know if you have any
> further thoughts / comments.
Thanks for incorporating the changes and fixing initial hash table size.
+ #define EC_DERIVES_HASH_THRESHOLD 32
Given that the constant is being used only at a single place, we don't
need a macro. But I am not against the macro.
PFA patch set with some minor edits in 0003. Also I have edited commit
message of 0001 and 0002.
In the commit messages of 0002,
1. mentioning that the lookup happens only for join clause generation
is not accurate, since we lookup EM = constant clauses as well which
are not join clauses.
2. In the second paragraph em1 and em2 are mentioned without
mentioning what are they. I have rephrased it so as to avoid
mentioning names of structure member.
--
Best Wishes,
Ashutosh Bapat